-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update composition tutorials for new tooling. #168
Conversation
Signed-off-by: Michael Carroll <michael@openrobotics.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but for a few nits!
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Resolved in commit before I realized that DCO isn't enforced here. |
I think the documentation should contain a section to explain how to add the component to the ament index, i.e. how to prevent: Edit: It turns out, you need to start the component process ( |
@christianrauch Yes, I'll note this, but the container process needs to have visibility into the workspace that it is trying to load components from, otherwise they won't appear in the index. Thanks for the feedback. |
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
This is to bring the tutorial inline with the enhancements made in the Dashing release.
WIP until a launch component demo is available.
Connects to #167