Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update composition tutorials for new tooling. #168

Merged
merged 5 commits into from
Apr 25, 2019
Merged

Conversation

mjcarroll
Copy link
Member

@mjcarroll mjcarroll commented Apr 16, 2019

This is to bring the tutorial inline with the enhancements made in the Dashing release.

WIP until a launch component demo is available.

Connects to #167

Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll requested a review from hidmic April 16, 2019 19:46
@mjcarroll mjcarroll self-assigned this Apr 16, 2019
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but for a few nits!

source/Tutorials/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Composition.rst Outdated Show resolved Hide resolved
source/Tutorials/Composition.rst Outdated Show resolved Hide resolved
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll
Copy link
Member Author

Resolved in commit before I realized that DCO isn't enforced here.

@christianrauch
Copy link
Contributor

christianrauch commented Apr 21, 2019

I think the documentation should contain a section to explain how to add the component to the ament index, i.e. how to prevent: Failed to load component: Could not find requested resource in ament index.

Edit: It turns out, you need to start the component process (ros2 run rclcpp_components component_container) from the workspace that contains the component. This should maybe be mentioned as it is currently a limitation. E.g. you cannot load components from different workspaces into the same process.

@mjcarroll
Copy link
Member Author

@christianrauch Yes, I'll note this, but the container process needs to have visibility into the workspace that it is trying to load components from, otherwise they won't appear in the index. Thanks for the feedback.

Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@wjwwood wjwwood merged commit 40b5b12 into master Apr 25, 2019
@delete-merged-branch delete-merged-branch bot deleted the update_composition branch April 25, 2019 00:16
@wjwwood wjwwood mentioned this pull request Apr 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants