-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage_factory_test is leaking memory #23
Comments
Yes, there are leaks from the pluginlib. Here is a minimal pluginlib example: https://github.com/bsinno/rosbag2/tree/pluginlib_leak_example
|
* GH-23 Get all topics from node and sanitize * GH-23 Move methods to node for better interface * GH-23 Use rmw_serialized_message_t consistently * GH-23 Improve santization of topics * GH-65 Introduce and use better logging macros * GH-23 Use publisher to serialized message directly * GH-23 Improve readability of sanitizing topics and types * GH-23 Allow to write all available topics * GH-23 Add test for record all * GH-23 Cleanup: add missing const ref to record interface * Cleanup for doxygen * Improve topic sanitization - correctly expand topic names using rcl - do not check type correctness (supposed to be done internally) * Pass topic_name by reference
closing this as it's more related to poco and pluginlib than to rosbag2 as-is. |
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp>
Signed-off-by: wep21 <border_goldenmarket@yahoo.co.jp> Signed-off-by: James Smith <james@foxglove.dev>
…23) Add `--append-files` option to `ros2 bag record`, and update `SequentialWriter` to allow adding files to an existing recording directory. Very useful for persistent "circular buffer" recording, especially in combination with `--max-bagfile-splits` Signed-off-by: Emerson Knapp <emerson.b.knapp@gmail.com>
When running the tests with valgrind, we can see that there is quite some memory leaked. It increases with every library loaded.
Some of the memory not being freed is due to the rcutils_loggig_macros.
I believe the rest of it is due to Pluginlib or Poco.
The text was updated successfully, but these errors were encountered: