[Backport/Humble] Notification of significant events during bag recording and playback #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#908) * Simple hacky prototype Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Improved prototype with more flexibility and event information Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Use the full relative file path for event info Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove no-longer required dependency Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove left-over merge Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Change event names Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add overrides to mocks Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add missing include Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove empty file Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove unnecessary virtual Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct formatting Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add missing doc Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Reformat documentation Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Change read event topic name Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Change read event topic name Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Simplify for loop Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove unnecessary blank line Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Change argument type to const Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add events handling to mocks Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add comment explaining 5-message split Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add integration tests for player and recorder Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add ability to check if an event has callbacks Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Shift event topic publishing to a separate thread Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Fix formatting Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Test SequentialReader event callbacks Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Test SequentialWriter event callbacks Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Document bag events Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Check if joinable before joining Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct spelling mistake Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Correct spelling mistake Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Reduce time wasted waiting for test to reach intended behaviour Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Address test flakiness Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Improve size check Co-authored-by: Michael Orlov <morlovmr@gmail.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Use constant for split size in tests Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add missing header Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Allocate thread on the stack Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add getters for number of messages per 'file' Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Replace magic number Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Address unstable OSX build Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Make path in test cross-platform Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com> Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Add missing virtual destructor Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Follow uncrustify suggestion Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Fix rebase errors Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> * Remove double include Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net> Co-authored-by: Michael Orlov <morlovmr@gmail.com> Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
gbiggs
requested review from
MichaelOrlov and
hidmic
and removed request for
a team
|
Gist: https://gist.githubusercontent.com/MichaelOrlov/6c1703180c5770c61d51d01a7b4f6539/raw/8c7b6492858213d297f35d2374807d7b894effaa/ros2.repos
|
audrow
approved these changes
Jul 6, 2022
|
Looks good to me. Are the PR job failures expected? |
Yes. It's known issue #862 |
|
@audrow Can we merge this PR now? |
|
Great, one more CI run, just to see if anything has changed - if this is green, I'll merge it:
|
|
@audrow Can we merge it now? |
This was referenced Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #908 to Humble.