Commits on Jul 4, 2022

1. Notification of significant events during bag recording and playback (… …

   …#908)
   
   * Simple hacky prototype
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Improved prototype with more flexibility and event information
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Use the full relative file path for event info
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Remove no-longer required dependency
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Remove left-over merge
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Change event names
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add overrides to mocks
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add missing include
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Remove empty file
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Remove unnecessary virtual
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Correct formatting
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add missing doc
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Reformat documentation
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Change read event topic name
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Change read event topic name
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Simplify for loop
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Remove unnecessary blank line
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Change argument type to const
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add events handling to mocks
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add comment explaining 5-message split
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add integration tests for player and recorder
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add ability to check if an event has callbacks
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Shift event topic publishing to a separate thread
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Fix formatting
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Test SequentialReader event callbacks
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Test SequentialWriter event callbacks
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Document bag events
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Check if joinable before joining
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Correct spelling mistake
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Correct spelling mistake
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Reduce time wasted waiting for test to reach intended behaviour
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Address test flakiness
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Improve size check
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Use constant for split size in tests
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add missing header
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Allocate thread on the stack
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add getters for number of messages per 'file'
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Replace magic number
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Address unstable OSX build
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Make path in test cross-platform
   
   Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Add missing virtual destructor
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Follow uncrustify suggestion
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Fix rebase errors
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   * Remove double include
   
   Signed-off-by: Geoffrey Biggs <gbiggs@killbots.net>
   
   Co-authored-by: Michael Orlov <morlovmr@gmail.com>
   Co-authored-by: Emerson Knapp <537409+emersonknapp@users.noreply.github.com>

   

   3 people committed Jul 4, 2022
   Configuration menu

   • View commit details
   • Copy full SHA for be44aa9
   • Browse repository at this point

   Copy the full SHA

   be44aa9 View commit details

   Browse the repository at this point in the history