Mark test_play_services as xfail for FastRTPS and CycloneDDS
#1091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Crola1702
requested review from
emersonknapp,
MichaelOrlov,
Blast545 and
clalancette
and removed request for
a team
|
CI launch builds:
|
Blast545
requested changes
Sep 16, 2022
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
|
CI launch builds with conditionals:
|
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Blast545
approved these changes
Sep 16, 2022
MichaelOrlov
approved these changes
Sep 19, 2022
delete-merged-branch
bot
deleted the
Crola1702/mark-test_play_services-as-xfail
branch
|
https://github.com/Mergifyio backport humble |
mergify bot
pushed a commit
that referenced
this pull request
Oct 24, 2022
* Mark test_play_services as xfail for fastrtps and cyclonedds Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com> (cherry picked from commit ae8a4c0)
✅ Backports have been created
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com
This PR Marks
test_play_servicestest as xfail for FastRTPS and CycloneDDS vendors.These test are failing flaky for a while. There is an issue open here about this problem.
Reference build (on FastRTPS)
Reference build (on CycloneDDS)
In the last two weeks:
Fastrtps fails about 4x more than CycloneDDS, but we are disabling it as well, as we are not planning to invest more resources investigating this issue in the near future.
Keeping track with @Blast545