Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test_play_services as xfail for FastRTPS and CycloneDDS #1091

Merged
merged 4 commits into from
Sep 19, 2022

Conversation

Crola1702
Copy link
Contributor

Signed-off-by: Crola1702 cristobal.arroyo@ekumenlabs.com

This PR Marks test_play_services test as xfail for FastRTPS and CycloneDDS vendors.

These test are failing flaky for a while. There is an issue open here about this problem.

Reference build (on FastRTPS)
Reference build (on CycloneDDS)

In the last two weeks:

  • It appeared 40 times in FastRTPs
  • and 11 times in CycloneDDS

Fastrtps fails about 4x more than CycloneDDS, but we are disabling it as well, as we are not planning to invest more resources investigating this issue in the near future.

Keeping track with @Blast545

Note:
I didn't figure out how to add ament_add_test_label(test_play_services xfail) without making build fail:

CMake Error at /home/agali/Desktop/docker_ws/ros2-rolling-ws/ws/install/ament_cmake_test/share/ament_cmake_test/cmake/ament_add_test_label.cmake:28 (set_tests_properties):
  set_tests_properties Can not find test to add properties to:
  test_play_services
Call Stack (most recent call first):
  CMakeLists.txt:248 (ament_add_test_label)

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702 Crola1702 requested a review from a team as a code owner September 15, 2022 16:00
@Crola1702 Crola1702 requested review from emersonknapp, MichaelOrlov, Blast545 and clalancette and removed request for a team September 15, 2022 16:00
@Crola1702
Copy link
Contributor Author

CI launch builds:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

rosbag2_transport/CMakeLists.txt Outdated Show resolved Hide resolved
Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
@Crola1702
Copy link
Contributor Author

Crola1702 commented Sep 16, 2022

CI launch builds with conditionals:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
Copy link
Contributor

@Blast545 Blast545 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rpr job passing, LGTM after full CI comes green

@Crola1702 Crola1702 merged commit ae8a4c0 into rolling Sep 19, 2022
@delete-merged-branch delete-merged-branch bot deleted the Crola1702/mark-test_play_services-as-xfail branch September 19, 2022 18:24
@Crola1702
Copy link
Contributor Author

https://github.com/Mergifyio backport humble

mergify bot pushed a commit that referenced this pull request Oct 24, 2022
* Mark test_play_services as xfail for fastrtps and cyclonedds

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
(cherry picked from commit ae8a4c0)
@mergify
Copy link

mergify bot commented Oct 24, 2022

backport humble

✅ Backports have been created

Crola1702 pushed a commit that referenced this pull request Oct 25, 2022
#1136)

* Mark test_play_services as xfail for fastrtps and cyclonedds

Signed-off-by: Crola1702 <cristobal.arroyo@ekumenlabs.com>
(cherry picked from commit ae8a4c0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants