[Design] Update record parameters #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
requested review from
gbiggs and
hidmic
and removed request for
a team
|
@MichaelOrlov Please help to review this PR. |
fujitatomoya
approved these changes
Oct 17, 2023
Signed-off-by: Barry Xu <barry.xu@sony.com>
MichaelOrlov
approved these changes
Oct 18, 2023
There was a problem hiding this comment.
@Barry-Xu-2018 Thanks for the changes in the design document.
Looks good to me.
Barry-Xu-2018
added a commit
to Barry-Xu-2018/rosbag2
that referenced
this pull request
Oct 18, 2023
Refer to ros2#1483 Signed-off-by: Barry Xu <barry.xu@sony.com>
roncapat
pushed a commit
to roncapat/rosbag2
that referenced
this pull request
Nov 4, 2023
* [Design] Update record parameters Signed-off-by: Barry Xu <barry.xu@sony.com> * Revise document regarding the misunderstood part. Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: roncapat <ronca.pat@gmail.com>
roncapat
pushed a commit
to roncapat/rosbag2
that referenced
this pull request
Nov 4, 2023
* [Design] Update record parameters Signed-off-by: Barry Xu <barry.xu@sony.com> * Revise document regarding the misunderstood part. Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
added a commit
to Barry-Xu-2018/rosbag2
that referenced
this pull request
Nov 14, 2023
Refer to ros2#1483 Signed-off-by: Barry Xu <barry.xu@sony.com>
Barry-Xu-2018
added a commit
to Barry-Xu-2018/rosbag2
that referenced
this pull request
Dec 13, 2023
Refer to ros2#1483 Signed-off-by: Barry Xu <barry.xu@sony.com>
MichaelOrlov
added a commit
that referenced
this pull request
Dec 21, 2023
…1480) * Implement service record and recorded service info display Signed-off-by: Barry Xu <barry.xu@sony.com> * Address MichaelOrlov's review comments Signed-off-by: Barry Xu <barry.xu@sony.com> * Add tests for rosbag2_cpp::Info::read_service_info() Signed-off-by: Barry Xu <barry.xu@sony.com> * Updated code on exclude parameters Refer to #1483 Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix flake8 errors Signed-off-by: Barry Xu <barry.xu@sony.com> * Update code to remove hard-coded values to make the code more readable Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix a bug on exclude parameter Signed-off-by: Barry Xu <barry.xu@sony.com> * Update codes on rosbag2 QoS for service event topic Signed-off-by: Barry Xu <barry.xu@sony.com> * Address the second round of review comments Signed-off-by: Barry Xu <barry.xu@sony.com> * Updated info test on getting service info Signed-off-by: Barry Xu <barry.xu@sony.com> * Rename exclude_services to exclude_service_event Signed-off-by: Barry Xu <barry.xu@sony.com> * Address flakiness in newly added rosbag2_transport tests - Got rid form ambient sleep for waiting for messages to be recorded - Exclude "/rosout" topic from recording Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use wait_for_srvice_to_be_ready() instead check_service_ready() - Also add default timeout parameter for ClientManager::send_request(..) Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add rosbag2_test_common::wait_until_condition(..) Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Rewrite get_service_info tests to be more deterministic - Also parameterize tests to use default supported storage plugins Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Renames in the get_service_info tests Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Use `std::filesystem` instead of `rcpputils::fs` functions - Rationale: Deprecation of the rcpputils::fs in future See ros2/rcpputils#164 for details Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Avoid extra metadata readout in `ros2 bag info` verb with `--verbose` Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Add info_end_to_end test with `--verbose` parameter Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Fix bugs in info_with_verbose_option_end_to_end_test Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix segment fault issue in test_rosbag2_cpp_get_service_info.cpp Signed-off-by: Barry Xu <barry.xu@sony.com> * Update a fix for info_with_verbose_option_end_to_end_test Signed-off-by: Barry Xu <barry.xu@sony.com> * Output a warning while setting both '-t' and 'v' for info command Signed-off-by: Barry Xu <barry.xu@sony.com> * Address comments from Fujita-san Signed-off-by: Barry Xu <barry.xu@sony.com> * Use topic_in_list instead of service_in_list Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Handle cases when dependent service msg definitions could be in IDL file Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Fix rebase errors - Delete "rosbag2_transport/qos.cpp" which was moved to the rosbag2_storage package during prior PR before rebase Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Fix the path of a library Signed-off-by: Barry Xu <barry.xu@sony.com> * Resolve the conflicts caused by the rebase Signed-off-by: Barry Xu <barry.xu@sony.com> * Replace sizeof() with strlen() Signed-off-by: Barry Xu <barry.xu@sony.com> * Use consistent variable name Signed-off-by: Barry Xu <barry.xu@sony.com> * Fix a link error on Windows Signed-off-by: Barry Xu <barry.xu@sony.com> * Use visibility control for format library Signed-off-by: Barry Xu <barry.xu@sony.com> * Replace rosbag2_format_output by direct source files linkage - Also put `format_service_info(..)` and `format_bag_meta_data(..)` under the rosbag2_py namespace Signed-off-by: Michael Orlov <michael.orlov@apex.ai> * Remove header files from pybind modules and delete visibility_control.hpp Signed-off-by: Michael Orlov <michael.orlov@apex.ai> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> Signed-off-by: Michael Orlov <michael.orlov@apex.ai> Co-authored-by: Michael Orlov <michael.orlov@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the proposal.
Item 2 in #1480 (comment)