-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add object representation and conversion from ast #326
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review. I have some questions about the definitions. With those answers I'll be better able to review the parser.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for now with a minor fix. There are limitations that should be ticketed like includes in modules and different constants in different messages. Tests with IDL files that are acceptable to the grammar but illogical, like a boolean constant being assigned a string value, would be good too, but that can be ticketed rather than blocking the remaining PRs.
Thanks. I created #329 for the followup improvements. Squashing the commits before the merge... |
202eb24
to
1d934b2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
green check mark
That is very suspicious because the PR job has no way of pulling the |
9b6076f
to
49b1eaa
Compare
@ros-pull-request-builder retest this please |
Waiting for the |
49b1eaa
to
8219e66
Compare
8219e66
to
363cade
Compare
|
49d24f2
to
edfcae2
Compare
This is the fifth PR integrating #298 step-by-step.
Builds on top of #325. Needs ros2/ci#220.
After lark parses any input file the AST is converted to an object representation (which will later be passed into the message generator templates).
Linux CI: