Break rosidl_defaults into rosidl_core and rosidl_defaults #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move contents of rosidl_default_generators into the new package. This package is contains dependencies for code generation of ROS messages. rosidl_default_generators now depends on the new package, plus message definitions required for Actions (namely action_msgs). This allows users to avoid having to explictly depend on action_msgs. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
…ult_runtime Signed-off-by: Brian Chen <brian.chen@openrobotics.org>
14 tasks
ivanpauno
reviewed
Aug 17, 2022
There was a problem hiding this comment.
I think that some of the changes overlap with #22, cc @jacobperron.
Besides some minor comments, LGTM!
|
|
||
| if(BUILD_TESTING) | ||
| find_package(ament_lint_auto REQUIRED) | ||
| ament_lint_auto_find_test_dependencies() | ||
| endif() | ||
|
|
||
| ament_package( |
Comment on lines
-12
to
-14
| ament_package( | ||
| CONFIG_EXTRAS "rosidl_default_runtime-extras.cmake.in" | ||
| ) |
|
Closing in favor of #22. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Break rosidl_default_runtime into rosidl_default_runtime and rosidl_core_runtime.
rosidl_core_runtimewill live in another repository (presumably https://github.com/ros2/rosidl_core) in order to avoid a dependency loop at a repository level.Depends on #22