fix: issue #918 #942
Open
fix: issue #918 #942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahcorde
approved these changes
Jan 24, 2023
|
|
The only thing I'll say is that ROS 1 has the exact same code: https://github.com/ros-visualization/rviz/blob/d122ab111213c3ad4ac50756e4fd933d01982263/src/rviz/display.cpp#L366-L367 So I'm not sure that this explains a difference in behavior. |
|
I have been using Rviz since ROS1 kinetic and this annoying behavior has always been present. (Not only when minimizing the window but also when switching between workspaces in Ubuntu) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image and Camera plugins disable automatically on rviz2 window minimization. This behavior is really annoying in particular when you have the plugin nested into groups (each time you minimize the rviz window you need to traverse the tree and enable to plugin again).
In rviz (ROS1) this is not the case, correct me if I am wrong.
This pull request aims to solve this "undesired" behavior taking the cue from the solution proposed by @kudoukidd in #918.
With this change the plugin does not disable automatically on window minimization.