Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image Display is auto-disabled after minimazing main window #918

Open
kudoukidd opened this issue Nov 1, 2022 · 3 comments
Open

Image Display is auto-disabled after minimazing main window #918

kudoukidd opened this issue Nov 1, 2022 · 3 comments
Labels
more-information-needed Further information is required

Comments

@kudoukidd
Copy link

Image Display is auto-disabled after minimazing main window in ROS2 Galactic/Humble, which is different from ROS1 Melodic/Noetic

@clalancette
Copy link
Contributor

Can you please be more specific? What's the behavior that you are seeing, and what do you expect to happen? Screenshots might help here.

@clalancette clalancette added the more-information-needed Further information is required label Nov 17, 2022
@kudoukidd
Copy link
Author

void Display::setAssociatedWidget(QWidget * widget)
{
if (associated_widget_panel_) {
disconnect(
associated_widget_panel_, SIGNAL(visibilityChanged(bool)), this,
SLOT(associatedPanelVisibilityChange(bool)));
disconnect(associated_widget_panel_, SIGNAL(closed()), this, SLOT(disable()));
}

associated_widget_ = widget;
if (associated_widget_) {
WindowManagerInterface * wm = context_->getWindowManager();
if (wm) {
associated_widget_panel_ = wm->addPane(getName(), associated_widget_);
connect(
associated_widget_panel_, SIGNAL(visibilityChanged(bool)), this,
SLOT(associatedPanelVisibilityChange(bool)));

connect(associated_widget_panel_, SIGNAL(closed()), this, SLOT(disable()));
associated_widget_panel_->setIcon(getIcon());
} else {
associated_widget_panel_ = nullptr;
associated_widget_->setWindowTitle(getName());
}
} else {
associated_widget_panel_ = nullptr;
}
}

There is a connection between associated_widget_panel_ RenderPanel visibility and Display "enability". When rviz main window is minimized by clicking minimize button, which makes ImageDisplay RenderPanel unvisible, the ImageDisplay would become disabled and has to be manually re-enabled by checking the ImageDisplay enable property.

There is a suppress_hiding_associated_widget_panel_ flag in rviz1 which is different from rviz2. I did not dig further because simply removing the connection works fine in my situation.

@MarcoMagriDev
Copy link

Same issue here. The same problem occurs also with the Camera Display plugin.

MarcoMagriDev added a commit to MarcoMagriDev/rviz that referenced this issue Jan 23, 2023
@MarcoMagriDev MarcoMagriDev mentioned this issue Jan 23, 2023
MarcoMagriDev added a commit to MarcoMagriDev/rviz that referenced this issue Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
more-information-needed Further information is required
Projects
None yet
Development

No branches or pull requests

3 participants