Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows failure of test_action_client_server with rclcpp client and rclpy server with rmw_cyclonedds_cpp #452

Closed
brawner opened this issue Nov 24, 2020 · 3 comments
Closed

Windows failure of test_action_client_server with rclcpp client and rclpy server with rmw_cyclonedds_cpp #452

brawner opened this issue Nov 24, 2020 · 3 comments
Assignees
@brawner
Labels
bug Something isn't working

Comments

@brawner
Copy link
Contributor

brawner commented Nov 24, 2020 •
edited
Loading

This was found by @azeey last week and was likely introduced during ros2/rclcpp#1404.

This test is failing with a very specific combination on Windows only and I don't have all the details yet. Opening this issue to track discussion.

Two of the 20 different combinations times out, everything else finishes in just a few seconds.
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1760/testReport/test_communication/TestActionClientServer/

The combination consistently fails while others consistently succeed.
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1759/testReport/test_communication/TestActionClientServer/test_client_finishes_in_a_finite_amount_of_time_Fibonacci_/
https://ci.ros2.org/view/nightly/job/nightly_win_rel/1755/testReport/test_communication/TestActionClientServer/
@brawner brawner mentioned this issue Nov 24, 2020
Merged
@brawner brawner changed the title Failure of test_action_client_server with rclcpp client and rclpy server with rmw_cyclonedds_cpp Windows failure of test_action_client_server with rclcpp client and rclpy server with rmw_cyclonedds_cpp Nov 24, 2020
@brawner
Copy link
Contributor Author

brawner commented Nov 24, 2020 •
edited
Loading

Trying to increase timeout of the failing test
Build Status

@brawner brawner self-assigned this Nov 24, 2020
@brawner brawner added the bug Something isn't working label Nov 24, 2020
@brawner
Copy link
Contributor Author

brawner commented Nov 24, 2020

Other tests that look like they are timing out for similar reasons (all rmw_cyclonedds_cpp):

https://ci.ros2.org/view/nightly/job/nightly_win_extra_rmw_rel/955/testReport/(root)/projectroot/test_client_scope_cpp__rmw_cyclonedds_cpp/
https://ci.ros2.org/view/nightly/job/nightly_win_extra_rmw_rel/955/testReport/(root)/projectroot/gtest_avoid_ros_namespace_conventions_qos__rmw_cyclonedds_cpp/
https://ci.ros2.org/view/nightly/job/nightly_win_extra_rmw_rel/955/testReport/(root)/projectroot/test_services_cpp__rmw_cyclonedds_cpp/

@ivanpauno ivanpauno mentioned this issue Nov 30, 2020
Merged
@brawner
Copy link
Contributor Author

brawner commented Dec 2, 2020

Should have been resolved by #454 and #455

@brawner brawner closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brawner brawner

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brawner