Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call rclcpp::init and rclcpp::shutdown in each test for test_rclcpp #454

Merged
merged 3 commits into from
Dec 1, 2020
Merged

Call rclcpp::init and rclcpp::shutdown in each test for test_rclcpp #454

merged 3 commits into from
Dec 1, 2020

Conversation

brawner
Copy link
Contributor

@brawner brawner commented Dec 1, 2020

We're seeing many hangs on windows CI jobs in these tests, and I think the issue can be resolved by ensuring that rclcpp::shutdown gets called for each invocation of rclcpp::init. In the process of addressing this, I noticed that the test_remote_parameters wasn't setting up the test cases correctly for each rmw_implementation.

There may be some uncrustify issues to cleanup.

Testing --packages-select test_rclcpp

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

Signed-off-by: Stephen Brawner brawner@gmail.com

@brawner
Fix test_rclcpp system tests
83e2fe3 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner brawner requested a review from clalancette December 1, 2020 02:14
clalancette
clalancette reviewed Dec 1, 2020
View reviewed changes
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've got some questions inline. Also, the Rpr job is unhappy for some reason.

test_rclcpp/test/test_spin.cpp Show resolved Hide resolved
test_rclcpp/test/test_spin.cpp Outdated Show resolved Hide resolved
test_rclcpp/test/test_spin.cpp Outdated Show resolved Hide resolved
test_rclcpp/test/test_timer.cpp Outdated Show resolved Hide resolved
@brawner
Cleanup
4770f4f 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
brawner
brawner commented Dec 1, 2020
View reviewed changes
Copy link
Contributor Author

@brawner brawner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the messy second commit. I didn't fully vet the first commit before pushing because it was taking eons to run and test on windows.

test_rclcpp/test/test_spin.cpp Show resolved Hide resolved
test_rclcpp/test/test_timer.cpp Outdated Show resolved Hide resolved
@brawner
Copy link
Contributor Author

brawner commented Dec 1, 2020

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@brawner
Add comment about test failure
1a4fa8f 
Signed-off-by: Stephen Brawner <brawner@gmail.com>
@brawner
Copy link
Contributor Author

brawner commented Dec 1, 2020

I discovered that the multi_consumer_clients test in test_multithreaded fails for cylonedds on my machine, because it exceeded cylonedds's hardcoded core count. I added a comment to the test describing the finding and a link to the relevant issue.

ros2/rmw_cyclonedds#268

Windows is unstable because of one cmake warning in fastcdr, but the tests otherwise pass.

@brawner brawner merged commit 1c69aa0 into master Dec 1, 2020
@delete-merged-branch delete-merged-branch bot deleted the brawner/fix-tests branch December 1, 2020 22:19
@brawner brawner mentioned this pull request Dec 2, 2020
Closed
@Blast545
Copy link

@Mergifyio backport foxy

mergify bot pushed a commit that referenced this pull request Jan 20, 2022
@brawner
Call rclcpp::init and rclcpp::shutdown in each test for test_rclcpp (#…
9cc8a7f 
…454)

* Fix test_rclcpp system tests

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Cleanup

Signed-off-by: Stephen Brawner <brawner@gmail.com>

* Add comment about test failure

Signed-off-by: Stephen Brawner <brawner@gmail.com>
(cherry picked from commit 1c69aa0)
@mergify mergify bot mentioned this pull request Jan 20, 2022
Closed
@mergify
Copy link

mergify bot commented Jan 20, 2022

backport foxy

✅ Backports have been created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brawner @Blast545 @clalancette