Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for BoundedPlainSequences #481

Merged
merged 1 commit into from
Aug 6, 2021
Merged

Conversation

sloretz
Copy link
Contributor

@sloretz sloretz commented Aug 5, 2021

test_communication makes tests for every message type in test_interface_files. This PR adds code support in the tests for the new message.

Requires ros2/rcl_interfaces#125 - together they should fix the nightlies

Signed-off-by: Shane Loretz <sloretz@openrobotics.org>
@sloretz
Copy link
Contributor Author

sloretz commented Aug 5, 2021

CI (build: --packages-up-to test_communication test: --packages-select test_msgs test_communication)

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@sloretz sloretz requested a review from hidmic August 5, 2021 23:58
@scpeters
Copy link

scpeters commented Aug 6, 2021

I take it the build.ros.org CI failed because it's using the released versions of dependencies instead of building ros2/rcl_interfaces#125 from source?

@clalancette
Copy link
Contributor

I take it the build.ros.org CI failed because it's using the released versions of dependencies instead of building ros2/rcl_interfaces#125 from source?

That's correct. We'll need to do a release of rosidl into Rolling to resolve that.

@hidmic
Copy link
Contributor

hidmic commented Aug 6, 2021

I can roll out the Rolling releases once ros2/rcl_interfaces#125 is in. ros2/rmw_implementation#193 needs them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants