Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimator documentation #18

Merged
merged 14 commits into from
Jul 9, 2024
Merged

Estimator documentation #18

merged 14 commits into from
Jul 9, 2024

Conversation

iandareid
Copy link
Contributor

Added documentation for the estimator.

@iandareid iandareid added the documentation Improvements or additions to documentation label Jun 24, 2024
@iandareid iandareid requested a review from JMoore5353 June 24, 2024 20:30
@iandareid iandareid self-assigned this Jun 24, 2024
@JMoore5353
Copy link
Contributor

On the Estimator Overview page, Figure 1 is listed in 2 places, which is a little confusing. As a reader, I would expect something to change between the two figures if they are listed twice... Maybe we take the second one out and just refer to the first one?

Copy link
Contributor

@JMoore5353 JMoore5353 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few comments... Let me know what you think.

@iandareid
Copy link
Contributor Author

On the Estimator Overview page, Figure 1 is listed in 2 places, which is a little confusing. As a reader, I would expect something to change between the two figures if they are listed twice... Maybe we take the second one out and just refer to the first one?

It was the wrong figure!

@iandareid iandareid requested a review from JMoore5353 June 25, 2024 23:17
@iandareid iandareid merged commit 944595a into main Jul 9, 2024
1 check passed
@iandareid iandareid deleted the estimator_documentation branch July 9, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants