add json outpuy #24
Closed
add json outpuy #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@rosswarren can evaluate? |
SmithChart
reviewed
Dec 23, 2023
epevermodbus/command_line.py
Outdated
| output["battery_discharge"] = controller.get_battery_discharge() | ||
| output["battery_charge"] = controller.get_battery_charge() | ||
| output["charging_mode"] = controller.get_charging_mode() | ||
| print(output) |
There was a problem hiding this comment.
Please use the builtin json.dumps(output) here.
Using a library we make sure that the json will always be well-formatted and can be read across platforms.
The Python str() output of a dict should not be considered stable.
|
pr updated |
|
@sante85 Thx! LGTM |
|
when you publish on pypi.org?
thanks
Il giorno dom 24 dic 2023 alle ore 13:42 SmithChart <
***@***.***> ha scritto:
… @sante85 <https://github.com/sante85> Thx! LGTM
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLHTN6TIKIYB5T4Z2KMHZTYLAPJRAVCNFSM6AAAAABA6VHHNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGUYDQMJSGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
hi Rosswarren/Epevermodbus,
when you think to publish?
thanks
Il giorno dom 24 dic 2023 alle ore 17:03 Sante Stanisci ***@***.***>
ha scritto:
… when you publish on pypi.org?
thanks
Il giorno dom 24 dic 2023 alle ore 13:42 SmithChart <
***@***.***> ha scritto:
> @sante85 <https://github.com/sante85> Thx! LGTM
>
> —
> Reply to this email directly, view it on GitHub
> <#24 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ADLHTN6TIKIYB5T4Z2KMHZTYLAPJRAVCNFSM6AAAAABA6VHHNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGUYDQMJSGQ>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
@SmithChart @rosswarren @hrford you are here to merge PR? thanks |
|
@sante85 Sorry, I am just a contributor and can not merge. |
|
Why the owner not merge?
Il ven 5 gen 2024, 19:20 SmithChart ***@***.***> ha scritto:
… @sante85 <https://github.com/sante85> Sorry, I am just a contributor and
can not merge.
—
Reply to this email directly, view it on GitHub
<#24 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADLHTN6MVH3LF2OCFR3WWWTYNA75TAVCNFSM6AAAAABA6VHHNCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNZZGA4DKMJTGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
i have update, @rosswarren @rafael2k @hrford please merge |
|
thank you, these changes have been incorporated into #26 so closing this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.