Add json output to commandline #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds json output to the command line tool. Co-authored-by: Chris Fiege <chris@tinyhost.de>
The list controller.battery_voltage_control_register_names and the method controller.get_battery_voltage_control_registers() are actually duplicates to the following methods. While it is fine to have both ways of reading the battery_voltage_control_registers from a library perspective (and we definitely want to have this feature for writing), we do not need to output all values two times on the command line. Removing the variant with the least pretty formatting.
|
this looks good thank you 👍 I agree the duplication is OK for now, at least it is obvious from looking at the code what is happening |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternate version to #24 .
I've taken @sante85 's branch tested it, fixed some bugs, and cleaned it up a bit. Thanks for the heavy lifting @sante85! :-)
I am not totally happy with the duplication in
command_line.pythat we get with this. But I am not sure if it is worth another level of abstraction either...@rosswarren If you do not want to add this feature let me know. I would, at least, like to remove the duplicate output of the battery status registers (see 067e0d4).