[SBUS2] Fix units reported in esc sensor and report rotorflight's rpm, instead of escData #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 10, 2024 16:08
Temperatures and pwm were reading wrong. Change rpm soruce to match rpm sensor, as erpm didn't seem to match actual headspeed in my tests with hobbywing v4 based esc. (align 300x combo esc)
|
Can't imagine why you would want to calc it on the radio! |
That is just how it is usually done on futaba radios. They just transmit the raw motor rpm sensor output and you would input the type of sensor (hal effect, brushless, motor, optical) and setup as needed. Letting this be handled by rotorflight makes more sense, since it already has all that information. |
rotorflight
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could not match rotorflight's rpm data with headspeed by setting the right gear ratio on the radio.
So it is probably better to set ratio to 1:1 in the radio and report rotorflight's rpm.