Windows: add TBB (and MinGW DLLs) to load path #118
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to #117. It isn't a full "fix" (arbitrary user configs could still run into similar problems and need to set their own
%PATH%
s correctly), but it attempts to be a bit friendlier.This is similar to code in cmdstanpy. The main difference is (in Python) it also uses
os.add_dll_directory
. This appears to have fixed the issue which was preventing us from running our Python tests on Windows in Github Actions, so I've re-enabled those.I'll do a follow on PR which tries to split the Windows CI in to separate jobs per-interface.
Note: This PR does not change the R interface, since R doesn't (yet) have any handling of where BridgeStan is installed (see #100)