-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Windows CI #119
Split Windows CI #119
Conversation
This PR after #118, check. After a cursory look, just one question. What do you think about adding Python 3.11 and Julia 1.8 to our test matrix? |
3b0778b
to
02799e2
Compare
@roualdes We currently test against Julia "1", which will be the latest full release in the 1.x series (right now it looks like that is 1.8.5). We also test against 1.6, since that is the oldest version we claim to support. Python 3.11 is probably a good idea to test against. I'd be a bit hesitant to do so on all platforms just because it would really increase the size of the testing matrix, unless you think we could test on 3.9 and 3.11, skipping 3.10 |
I like the idea of testing an earlier version, namely 3.9, and the latest release, 3.11, but I'm not sure how much this preference corresponds with any tangible aspect of reality. For instance, just because we test at some made up ends of this range of Python versions doesn't really guarantee that everything in between works, e.g. re #118 os.add_dll_directory is version dependent. Further, I have no sense of how frequently people stay up to date on their Python versions. So I'm not sure what ditching 3.10 in favor of 3.11 gets us. I could go either way on this one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR looks good to me. The cleaned up workflow is nice. Thanks.
This is based on #118 and should be merged second. Dramatically cleans up our CI action and makes Windows tests more similar to the other platforms.