Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Since we use rpmtsAddReinstallElement rpm also uninstalls the package #1660

Merged
merged 1 commit into from
May 15, 2024
Merged

Since we use rpmtsAddReinstallElement rpm also uninstalls the package #1660

merged 1 commit into from
May 15, 2024

Commits on May 3, 2024

  1. Since we use rpmtsAddReinstallElement rpm also uninstalls the package 

    It calls callbacks for `RPMCALLBACK_INST_START` and
`RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done
through regural install (rpmtsAddInstallElement) but in addition it also
calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To
ensure they find the `DnfPackage` add it to `remove_helper` array.

Unfortunaly this means that the reinstall action is reported twice to
the clients (one install and one uninstall). We could try to hide one of
the them but I think a better solution is to report what is actually
happening and report one install and one uninstall.

This is for the context part of libdnf (microdnf, packagekit, ...)

Fixes: rpm-software-management#1653
    @kontura
    kontura committed May 3, 2024
    Configuration menu
    Copy the full SHA
    60c328f View commit details
    Browse the repository at this point in the history