rhel-9.5: Fix for RHEL-1454 #1663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upstream commit: 85432df `rpmtsAddInstallElement()` doesn't work for all reinstall cases, such as when a package `Provides` and `Conflicts` with the same capability. Fixes: rpm-software-management/microdnf#137 Resolves: https://issues.redhat.com/browse/RHEL-1454
Upstream commit: bc37168 It calls callbacks for `RPMCALLBACK_INST_START` and `RPMCALLBACK_INST_PROGRESS` just like before when the reinstall was done through regural install (rpmtsAddInstallElement) but in addition it also calls `RPMCALLBACK_UNINST_START` and `RPMCALLBACK_UNINST_PROGRESS`. To ensure they find the `DnfPackage` add it to `remove_helper` array. Unfortunaly this means that the reinstall action is reported twice to the clients (one install and one uninstall). We could try to hide one of the them but I think a better solution is to report what is actually happening and report one install and one uninstall. This is for the context part of libdnf (microdnf, packagekit, ...) Fixes: rpm-software-management#1653 Resolves: https://issues.redhat.com/browse/RHEL-1454
kontura
approved these changes
May 20, 2024
kontura
merged commit 7a3d4ed
into
rpm-software-management:rhel-9.5
2 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream commit: 90d2ffa
Upstream commit: 85432df
Resolves: https://issues.redhat.com/browse/RHEL-1454
Tests: rpm-software-management/ci-dnf-stack#1507
@kontura, could you please review this backport for rhel-9.5 of your upstream commits?