Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove subkey support from the internal OpenPGP parser #2278

Closed
pmatilai opened this issue Nov 18, 2022 · 1 comment
Closed

Remove subkey support from the internal OpenPGP parser #2278

pmatilai opened this issue Nov 18, 2022 · 1 comment
Assignees
@pmatilai

Comments

@pmatilai
Copy link
Member

We wont be able to get rid of the internal OpenPGP parser in 4.19, and even beyond that it could be useful as a bootstrap survival aid. But if it is to stay at all, we need to cut down on the complexity dramatically. By far the most complexity comes through subkeys whose handling still has any number of severe gaps and flaws despite the complexity. So we'll effectively turn back clock to time before 355c9b0, and a whole mountain of complexities just disappears.
@pmatilai pmatilai added this to the 4.19.0 milestone Nov 18, 2022
@pmatilai pmatilai added this to RPM Nov 18, 2022
@pmatilai pmatilai moved this to Backlog in RPM Nov 18, 2022
@pmatilai pmatilai mentioned this issue Nov 18, 2022
Closed
@pmatilai pmatilai moved this from Backlog to Todo in RPM Nov 18, 2022
@pmatilai pmatilai mentioned this issue Nov 18, 2022
Closed
pmatilai added a commit to pmatilai/rpm that referenced this issue Nov 18, 2022
@pmatilai
Drop subkey support from the internal OpenPGP parser
3fb23b6 
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Fixes: rpm-software-management#2278
pmatilai added a commit to pmatilai/rpm that referenced this issue Nov 18, 2022
@pmatilai
Drop subkey support from the internal OpenPGP parser
4720585 
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Fixes: rpm-software-management#2278
@pmatilai pmatilai mentioned this issue Nov 18, 2022
Closed
pmatilai added a commit to pmatilai/rpm that referenced this issue Nov 18, 2022
@pmatilai
Drop subkey support from the internal OpenPGP parser
ca75034 
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Update tests accordingly - as a nice side-effect this makes the internal
parser behave the same as Sequoia for these cases.

Fixes: rpm-software-management#2278
pmatilai added a commit to pmatilai/rpm that referenced this issue Nov 18, 2022
@pmatilai
Drop subkey support from the internal OpenPGP parser
8ea3dd3 
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Update tests accordingly - as a nice side-effect this makes the internal
parser behave the same as Sequoia for these cases.

Fixes: rpm-software-management#2278
pmatilai added a commit to pmatilai/rpm that referenced this issue Nov 18, 2022
@pmatilai
Drop subkey support from the internal OpenPGP parser
954a11e 
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Update tests accordingly - as a nice side-effect this makes the internal
parser behave the same as Sequoia for these cases.

Fixes: rpm-software-management#2278
pmatilai added a commit to pmatilai/rpm that referenced this issue Nov 18, 2022
@pmatilai
Drop subkey support from the internal OpenPGP parser
32893a5 
The world of OpenPGP subkeys is scarily complicated and we're failing at
it in too many ways to count. People who need the complexity of a full
implementation can use the Sequoia backend, meanwhile this tames the
internal parser back to something we may be able to support.

Update tests accordingly - as a nice side-effect this makes the internal
parser behave the same as Sequoia for these cases.

Fixes: rpm-software-management#2278
@pmatilai pmatilai moved this from Todo to In Review in RPM Nov 22, 2022
@pmatilai pmatilai moved this from In Review to Todo in RPM Jan 25, 2023
@pmatilai pmatilai modified the milestones: 4.19.0, 4.20.0 Aug 28, 2023
@pmatilai
Copy link
Member Author

We can't push a change like this in at the RC stage so we'll just have to ack that we missed the boat this time around. And since that was the case, we'll better be looking at getting rid of the whole thing instead. So closing in favor of #2414.

@github-project-automation github-project-automation bot moved this from Todo to Done in RPM Aug 28, 2023
@ppisar ppisar mentioned this issue Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pmatilai pmatilai

Labels
None yet
Projects
RPM
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop subkey support from the internal OpenPGP parser pmatilai/rpm
1 participant
@pmatilai