Skip similar nodegroup recomputation #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dale Smith <dale@catalystcloud.nz>
Generated by: ``` UPSTREAM_REF=v2.8.0 hack/update-vendor.sh ```
I have to agree with the removed comment, the previous interface was very weird to hold. hcloud-go 2.8.0 introduced a new `WaitFor()` interface that simplifies this a lot. The custom handler is no longer required.
Show requests/responses made towards Hetzner cloud for high log levels
…s.io ProvisioningRequests (kubernetes#6824) * Add support for atomic scale-up provisioning request class * review fixes
…o-2.8.0 chore(deps): update vendored hcloud-go to 2.8.0
Bump the go version for the GitHub workflows.
…owed-log Add more precise logging for VPA resource recommendations
Minor documentation and comment typo fixes
…num/cluster-autoscaler_image_version Bump openstackmagnum/cluster-autoscaler image version.
Bumps golang from 1.22.3 to 1.22.4. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps golang from 1.22.3 to 1.22.4. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps golang from 1.22.3 to 1.22.4. --- updated-dependencies: - dependency-name: golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…eouts Fix GCE client long polling timeouts.
…hestrator Public ProvisioningClass interface
…-processor Use the same processors for all currently supported provisioning classes
… changes The current CA master depends on the newest version of the APIs module, but it's not expressed in its go.mod.
Bump the cluster-autoscaler/apis dependency in CA go.mod after recent changes
…gnore-nodegroupset azure labels to skip in nodegroupset
…o-owners VPA - Add voelzmo to approvers
Add ProvisioningRequestNoCache method to test client
…vertical-pod-autoscaler/pkg/updater/golang-1.22.4 Bump golang from 1.22.3 to 1.22.4 in /vertical-pod-autoscaler/pkg/updater
…vertical-pod-autoscaler/pkg/admission-controller/golang-1.22.4 Bump golang from 1.22.3 to 1.22.4 in /vertical-pod-autoscaler/pkg/admission-controller
…vertical-pod-autoscaler/pkg/recommender/golang-1.22.4 Bump golang from 1.22.3 to 1.22.4 in /vertical-pod-autoscaler/pkg/recommender
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This used to only occur when the bestOption NodeGroup did not exist, but was changed in kubernetes#5802. There are cases where an expander could modify the bestOption's similar nodegroups, such as custom logic in the gRPC expander.
In cases like this, we should have a CLI option to trust expander’s similar nodegroups and skip the recomputation as long as the
bestOptionnodegroup exists. If it doesn’t exist, then we can create it and compute the similar options (I am also open to changing the PR to skipping recomputation when the nodegroup does not exist too).If a user does not enable this option, then by default the behaviour will stay the same. This will only skip similar nodegroup recomputation for users who enable this option.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: