Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: not disposing autoDispose family provider #2481

Merged
merged 6 commits into from
Apr 24, 2023

Conversation

jeiea
Copy link
Contributor

@jeiea jeiea commented Apr 21, 2023

Close #2480.

@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #2481 (6826e5b) into master (41cdfa5) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2481      +/-   ##
==========================================
- Coverage   95.25%   95.24%   -0.01%     
==========================================
  Files          53       53              
  Lines        2253     2252       -1     
==========================================
- Hits         2146     2145       -1     
  Misses        107      107              
Impacted Files Coverage Δ
...lib/src/change_notifier_provider/auto_dispose.dart 100.00% <ø> (ø)
packages/riverpod/lib/src/async_notifier/base.dart 100.00% <ø> (ø)
packages/riverpod/lib/src/framework/family.dart 100.00% <ø> (ø)
.../lib/src/state_notifier_provider/auto_dispose.dart 100.00% <ø> (ø)
packages/riverpod/lib/src/framework/container.dart 97.74% <100.00%> (-0.02%) ⬇️

@rrousselGit rrousselGit marked this pull request as ready for review April 24, 2023 10:06
Check format/analysis only on master
@rrousselGit rrousselGit merged commit b8bde8b into rrousselGit:master Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nested ProviderScope fix breaks family providers(?)
2 participants