fix: not disposing autoDispose family provider

packages/riverpod/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 - Improved error message for missing `dependencies` (thanks to @ValentinVignal)
 - Fixed various typos in the documentation (thanks to @ValentinVignal)
+- Fix not disposing autoDispose family providers
 
 ## 2.3.5 - 2023-04-18
 

packages/riverpod/lib/src/framework/container.dart

@@ -327,8 +327,7 @@ class ProviderContainer implements Node {
       // on provider dispose, to avoid memory leak
 
       void removeStateReaderFrom(ProviderContainer container) {
-        final reader = container._stateReaders[element._origin];
-        if (reader?.override == provider) {
+        if (container._stateReaders[element._origin] == reader) {
           container._stateReaders.remove(element._origin);
         }
         container._children.forEach(removeStateReaderFrom);

packages/riverpod/test/framework/auto_dispose_test.dart

@@ -529,6 +529,33 @@ final alwaysAlive = Provider((ref) {
     expect(container.getAllProviderElements(), isEmpty);
   });
 
+  test(
+      'when cancel autoDispose family override it should be disposed immediately',
+      () async {
+    final provider = Provider.autoDispose.family<int, int>((ref, _) => -1);
+
+    var constructionCount = 0;
+    final override = Provider.autoDispose.family<int, int>((ref, _) {
+      return ++constructionCount;
+    });
+
+    final overriden = provider.overrideWithProvider(override);
+    final root = createContainer();
+    final container = createContainer(
+      parent: root,
+      overrides: [overriden],
+    );
+
+    final instance1 = provider(0);
+    var count = container.read(instance1);
+    expect(count, 1);
+    await container.pump();
+
+    final instance2 = provider(0);
+    count = container.read(instance2);
+    expect(count, 2);
+  });
+
   test(
       'can select auto-dispose providers if the selecting provider is auto-dispose too',
       () {