Use learnr for praise and encouragement and deprecate random_encourage() #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schloerke
requested changes
Jan 4, 2021
Avoids some weird behavior that can happen if learnr is updated but gradethis isn't rebuilt Co-authored-by: Barret Schloerke <barret@rstudio.com>
gadenbuie
added a commit
to gadenbuie/learnr
that referenced
this pull request
Jan 4, 2021
And require learnr >= 0.10.1.9007 where "Correct!" was removed from the praise message
schloerke
approved these changes
Jan 5, 2021
|
Let's wait to merge until rstudio/learnr#463 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.