Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Correct!" from random_praise() #463

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Remove "Correct!" from random_praise() #463

merged 2 commits into from
Jan 5, 2021

Conversation

gadenbuie
Copy link
Member

Removes Correct! from random_praise() phrases, for consistency with random_encouragement().

Closes #453

  • Update NEWS
  • Add tests (if possible)
  • Update documentation with devtools::document()

@schloerke schloerke mentioned this pull request Jan 5, 2021
Merged
@gadenbuie gadenbuie merged commit c29fa10 into rstudio:master Jan 5, 2021
@gadenbuie gadenbuie deleted the remove-correct-random-praise branch January 5, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make "Correct!" optional in random_praise()
2 participants
@gadenbuie @schloerke