Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Correct!" from random_praise() #463

Merged
merged 2 commits into from
Jan 5, 2021
Merged

Remove "Correct!" from random_praise() #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57397c1
Remove "Correct!" from random_praise()
gadenbuie Jan 4, 2021
44b22b5
Bump dev version 0.10.1.9007
gadenbuie Jan 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: learnr
Type: Package
Title: Interactive Tutorials for R
Version: 0.10.1.9006
Version: 0.10.1.9007
Authors@R: c(
person("Barret", "Schloerke", role = c("aut", "cre"), email = "barret@rstudio.com",
comment = c(ORCID = "0000-0001-9986-114X")),
Expand Down
3 changes: 2 additions & 1 deletion NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,11 @@ learnr (development version)
## Breaking Changes

* Renamed the `exercise_submission` event to `exercise_result` and added the following fields:
1. `id` - a randombly generated identifier that can be used to align with the associated `exercise_result` event.
1. `id` - a randomly generated identifier that can be used to align with the associated `exercise_result` event.
2. `time_elapsed` - the time required to run the exercise (in seconds)
3. `timeout_exceeded` - indicates whether the exercise was interrupted due to an exceeded timeout. May be `NA` for some platforms/evaluators if that information is not known or reported. ([#337](https://github.com/rstudio/learnr/pull/337))
* If a `-code-check` chunk returns feedback for an exercise submission, the result of the exercise is no longer displayed for a correct answer (only the feedback is displayed). If both the result and feedback should be displayed, all checking should be performed in a `-check` chunk (i.e., don't provide a `-code-check` chunk). ([#403](https://github.com/rstudio/learnr/pull/403))
* `random_praise()` no longer includes the phrase _Correct!_. Instead, it returns a random praising statement. ([#463](https://github.com/rstudio/learnr/pull/463), [#453](https://github.com/rstudio/learnr/issues/453))

## New features

Expand Down
2 changes: 1 addition & 1 deletion R/praise.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ random_encouragements <- c(
#' @export
#' @rdname random_praise
random_praise <- function() {
paste0("Correct! ", sample(random_praises, 1))
sample(random_praises, 1)
}
#' @export
#' @rdname random_praise
Expand Down