Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make "Correct!" optional in random_praise() #453

Closed
gadenbuie opened this issue Dec 11, 2020 · 1 comment · Fixed by #463
Closed

Make "Correct!" optional in random_praise() #453

gadenbuie opened this issue Dec 11, 2020 · 1 comment · Fixed by #463

Comments

@gadenbuie
Copy link
Member

learnr/R/praise.R

Lines 64 to 66 in 7eb2b29

random_praise <- function() {
paste0("Correct! ", sample(random_praises, 1))
}

The Correct! prefix is hardcoded. Removing it or making it optional would let other packages more easily drop random_praise() into their messages.

@gadenbuie
Copy link
Member Author

We're leaning toward removing the "Correct! " for consistency with random_encouragement() and to give authors more flexibility to include random praise in other places in feedback messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant