Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Mathjax in quiz questions #281

Merged
merged 5 commits into from
Oct 31, 2019
Merged

Enable Mathjax in quiz questions #281

merged 5 commits into from
Oct 31, 2019

Conversation

schloerke
Copy link
Collaborator

If text is formatted for mathjax, it is never triggered to be rendered.

run_tutorial("quiz_question", "learnr")
# Look at `Formatting and Math` section in `Overview`

PR task list:

  • [NA] Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()

@schloerke schloerke added the type: bug Maintainers have validated that it is a real bug in the project code label Sep 18, 2019
@schloerke schloerke added this to the 0.10.0 milestone Sep 18, 2019
@schloerke schloerke self-assigned this Sep 18, 2019
@schloerke schloerke requested review from wch and removed request for jcheng5 October 3, 2019 21:33
wch
wch reviewed Oct 28, 2019
View reviewed changes
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary? Can users just wrap their code with withMathJax()?

My main concern is that this will cause the MathJax JS file to be downloaded every time.

@schloerke
Copy link
Collaborator Author

Have restructured the PR to call a JS method to run mathjax. Mathjax is included by default in the rmarkdown document (even if mathjax is not required). If mathjax isn't found, nothing is triggered. If mathjax isn't found, this will be because the user has removed it.

@schloerke schloerke requested a review from wch October 28, 2019 19:36
@schloerke
Merge branch 'master' into mathjax
402c84d 
* master:
  remove bad pkg names when finding deps (#292)
  Tweak css to make sure buttons do not have margins below them
  turn question message vectors into lists
  Update 00-setup.Rmd
@schloerke schloerke merged commit c2d9fd4 into master Oct 31, 2019
@schloerke schloerke deleted the mathjax branch October 31, 2019 14:23
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into docs
fcf0030 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into rc-v0.10.0
5d99dc5 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into disk_answers
7c6c0eb 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees

@schloerke schloerke

Labels
type: bug Maintainers have validated that it is a real bug in the project code
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
2 participants
@schloerke @wch