Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix message logic for checkbox questions #299

Merged
merged 5 commits into from
Oct 31, 2019
Merged

fix message logic for checkbox questions #299

merged 5 commits into from
Oct 31, 2019

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Oct 29, 2019 •
edited
Loading

Fixes #293
Fixes #296

@schloerke
fix message logic for checkbox questions
e65fcf4 
was including correct messages when incorrect answers were also selected
@schloerke schloerke added this to the 0.10.0 milestone Oct 29, 2019
@schloerke schloerke requested a review from wch October 29, 2019 20:20
@schloerke schloerke self-assigned this Oct 29, 2019
@schloerke schloerke merged commit 640cd14 into master Oct 31, 2019
@schloerke schloerke deleted the checkbox_messages branch October 31, 2019 14:24
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into docs
fcf0030 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into rc-v0.10.0
5d99dc5 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
schloerke added a commit that referenced this pull request Oct 31, 2019
@schloerke
Merge branch 'master' into disk_answers
7c6c0eb 
* master:
  Move examples into tutorials and update website (#294)
  fix message logic for checkbox questions and html output in question messages (#299)
  Enable Mathjax in quiz questions (#281)
  Maintain knitr's output handler (#288)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
0.10.0
2 participants
@schloerke @wch