Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump localforage version and add "Close other tutorials" message after 5 seconds #302

Closed
wants to merge 3 commits into from
Closed

Bump localforage version and add "Close other tutorials" message after 5 seconds #302

wants to merge 3 commits into from

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Nov 4, 2019 •
edited
Loading

  • Updated localforage from v1.5.0 to v1.7.3. Changelog
  • If the tutorial is not displayed after 5 seconds, display a message in the quiz area. This should be done for all loading text information, so the "close tabs" div is added at display time.

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • Update documentation with devtools::document()

@schloerke schloerke self-assigned this Nov 4, 2019
@schloerke schloerke added this to the 0.10.0 milestone Nov 4, 2019
@schloerke schloerke requested a review from wch November 4, 2019 16:44
@schloerke schloerke mentioned this pull request Nov 6, 2019
Merged
2 tasks
@schloerke schloerke deleted the indexeddb branch November 6, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch Awaiting requested review from wch

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
0.10.0
Development

Successfully merging this pull request may close these issues.
1 participant
@schloerke