Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use indexedDB directly via idb-keyval #305

Merged
merged 11 commits into from
Nov 6, 2019
Merged

Use indexedDB directly via idb-keyval #305

merged 11 commits into from
Nov 6, 2019

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Nov 6, 2019

Fixes #304
Fixes #302

(View diff with white space turned off.)

Notes:
https://github.com/rstudio/learnr/pull/305/files?utf8=✓&diff=split&w=1#diff-c7d58e72ba1e4c97d7f872330fd63d87R1473-R1494

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()
  • Update authors in DESCRIPTION

Includes code from https://github.com/jakearchibald/idb-keyval/pull/73/files#diff-32d9810b60fe9355ae31121d8cc181e2

All store interactions must open store, do work on store, then close store
@schloerke schloerke added this to the 0.10.0 milestone Nov 6, 2019
@schloerke schloerke self-assigned this Nov 6, 2019
@schloerke schloerke requested a review from wch November 6, 2019 04:54
NEWS.md Outdated Show resolved Hide resolved
inst/lib/tutorial/tutorial.js Outdated Show resolved Hide resolved
inst/lib/tutorial/tutorial.js Outdated Show resolved Hide resolved
@wch
Copy link
Collaborator

wch commented Nov 6, 2019

We should also include license information for idb-keyval.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quiz questions are not loading when using multiple tabs
2 participants