Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .on("load", fn) as .load(fn) has been deprecated #326

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Use .on("load", fn) as .load(fn) has been deprecated #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b14be2e
Use `.on("load", fn)` as `.load(fn)` has been deprecated
schloerke Feb 9, 2020
3ff1510
add news item
schloerke Feb 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@ learnr 0.10.0.9000 (unreleased)

* Fixed extra parameter documentation bug. ([#323](https://github.com/rstudio/learnr/pull/323))

* Fixed video initialization error caused by a jQuery version increase in Shiny. ([#326](https://github.com/rstudio/learnr/pull/#326))


learnr 0.10.0
===========
Expand Down
2 changes: 1 addition & 1 deletion inst/lib/tutorial/tutorial.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ Tutorial.prototype.$injectScript = function(src, onload) {
script.src = src;
var firstScriptTag = document.getElementsByTagName('script')[0];
firstScriptTag.parentNode.insertBefore(script, firstScriptTag);
$(script).load(onload);
$(script).on("load", onload);
};

Tutorial.prototype.$debounce = function(func, wait, immediate) {
Expand Down