Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use .on("load", fn) as .load(fn) has been deprecated #326

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Use .on("load", fn) as .load(fn) has been deprecated #326

merged 2 commits into from
Feb 10, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Feb 9, 2020 •
edited

Fixes #315

PR task list:

  • Update NEWS
  • [NA] Add tests (if possible)
  • [NA] Update documentation with devtools::document()

@schloerke schloerke self-assigned this Feb 9, 2020
trestletech
trestletech approved these changes Feb 10, 2020
View reviewed changes
Copy link
Contributor

@trestletech trestletech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a video-based tutorial handy, so I didn't test this myself. But it seems sensible based on the point you made about jQuery 3.

@schloerke schloerke merged commit 3fab239 into master Feb 10, 2020
@schloerke schloerke deleted the jquery-onload branch February 10, 2020 15:55
schloerke added a commit that referenced this pull request Feb 12, 2020
@schloerke
Merge branch 'master' into v0.10.1-rc
c5abcac 
* master:
  implement tutorial_package_dependencies() (#329)
  Fix progressive reveal and Topics with special characters not loading (#330)
  Remove dead event, clarify Rmd/HTML docs (#331)
  Add session start/stop events (#328)
  Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wch wch wch approved these changes

@trestletech trestletech trestletech approved these changes

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaScript error on load
3 participants
@schloerke @wch @trestletech