Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement tutorial_package_dependencies() #329

Merged
merged 12 commits into from
Feb 12, 2020
Merged

implement tutorial_package_dependencies() #329

merged 12 commits into from
Feb 12, 2020

Conversation

kevinushey
Copy link
Collaborator

For front-ends that might want to enumerate a tutorial's required R package dependencies.

This is admittedly quick-and-dirty; @schloerke let me know if this looks okay or if you'd prefer some tweaks.

kevinushey
kevinushey commented Feb 11, 2020
View reviewed changes
NAMESPACE Outdated Show resolved Hide resolved
@schloerke schloerke self-assigned this Feb 12, 2020
@schloerke schloerke requested a review from wch February 12, 2020 15:25
@schloerke
Copy link
Collaborator

Two major changes.

  • Adds column package_dependencies to available_tutorials() output
  • Adds function tutorial_package_dependencies()

wch
wch previously requested changes Feb 12, 2020
View reviewed changes
Copy link
Collaborator

@wch wch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few comments on this PR. There's also a test that's failing on older versions of R:
https://github.com/rstudio/learnr/pull/329/checks?check_run_id=441404857#step:9:87

NEWS.md Outdated Show resolved Hide resolved
R/tutorial_package_dependencies.R Outdated Show resolved Hide resolved
R/tutorial_package_dependencies.R Outdated Show resolved Hide resolved
tests/testthat/test-dependency.R Outdated Show resolved Hide resolved
@schloerke schloerke self-requested a review February 12, 2020 21:47
@schloerke schloerke requested review from wch and removed request for wch February 12, 2020 21:48
@schloerke schloerke dismissed wch’s stale review February 12, 2020 21:48

Need to merge PR

@schloerke schloerke changed the title implement tutorial_dependencies() implement tutorial_package_dependencies() Feb 12, 2020
@schloerke schloerke merged commit 89c1d14 into master Feb 12, 2020
@schloerke schloerke deleted the feature/tutorial-dependencies branch February 12, 2020 21:50
schloerke added a commit that referenced this pull request Feb 12, 2020
@schloerke
Merge branch 'master' into v0.10.1-rc
c5abcac 
* master:
  implement tutorial_package_dependencies() (#329)
  Fix progressive reveal and Topics with special characters not loading (#330)
  Remove dead event, clarify Rmd/HTML docs (#331)
  Add session start/stop events (#328)
  Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schloerke schloerke schloerke approved these changes

@wch wch wch left review comments

Assignees

@schloerke schloerke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kevinushey @schloerke @wch