Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead event, clarify Rmd/HTML docs #331

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Conversation

trestletech
Copy link
Contributor

It appears that exercise_error in the docs is no longer valid. That string doesn't exist in the code -- at least not anymore. When I submit an invalid exercise, I get an excercise_submission event with an error field.

e.g. if I submit stop("what") in an exercise, I get this event:

com.rstudio.primers.02-vis-basics (1): jeff
event: exercise_submission
$label
[1] "mpg0"
$code
[1] "x <- 1\nx\nstop(\"what\")\n\nflarg"
$output
<div class="alert alert-danger" role="alert">what</div>
$error_message
[1] "what"
$checked
[1] FALSE
$feedback
NULL

Also fixes #327

@trestletech trestletech merged commit bb36e1f into master Feb 12, 2020
@trestletech trestletech deleted the jeff-publishing branch February 12, 2020 17:13
schloerke added a commit that referenced this pull request Feb 12, 2020
* master:
  implement tutorial_package_dependencies() (#329)
  Fix progressive reveal and Topics with special characters not loading (#330)
  Remove dead event, clarify Rmd/HTML docs (#331)
  Add session start/stop events (#328)
  Use `.on("load", fn)` as `.load(fn)` has been deprecated (#326)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation - Tell users to not include .html tutorial files
2 participants