Fix loading placeholder when question text is HTML #450
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
question()
accepts HTML for thetext
argument, in particular usinghtmltools
tags. But the default value of theloading
argument usesc()
to concatenatec("Loading...", text)
, which results in an unusual list thatquiz_text()
isn't expecting andmarkdown::renderMarkdown()
throws an error.I just changed the default to
c("Loading", format(text))
so that the shiny tags are formatted as a character.PR task list:
devtools::document()
I'll add a NEWS item if the PR looks good to you.