Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add numeric question type #461

Merged
merged 5 commits into from
Jan 4, 2021
Merged

Conversation

gadenbuie
Copy link
Member

@gadenbuie gadenbuie commented Dec 30, 2020

This PR adds a new numeric question type for use when tutorial authors explicilty want users to enter a number.

question-numeric

Requires #450, which lets answer() accept non-character text inputs (this PR can subsume #450 or I can rebase this PR after #450 is merged).

PR task list:

  • Update NEWS
  • Add tests (if possible)
  • Update documentation with devtools::document()
  • Update Quiz Questions example tutorial

R/quiz.R Show resolved Hide resolved
Copy link
Collaborator

@schloerke schloerke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Don't know if we want to change the auto question type behavior. I'm on the fence.

@schloerke schloerke merged commit 4b9cc8a into rstudio:master Jan 4, 2021
@gadenbuie gadenbuie deleted the question-numeric branch January 4, 2021 19:40
sjgknight pushed a commit to sjgknight/learnr that referenced this pull request Aug 10, 2021
gadenbuie added a commit that referenced this pull request Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants