Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If routes do not start with a /, should it be prepended? #625

Closed
schloerke opened this issue Jul 31, 2020 · 0 comments · Fixed by #656
Closed

If routes do not start with a /, should it be prepended? #625

schloerke opened this issue Jul 31, 2020 · 0 comments · Fixed by #656
Labels
difficulty: novice Anyone could help effort: low < 1 day of work help wanted Solution is well-specified enough that any community member could fix
Milestone
v1.0.0

Comments

@schloerke
Copy link
Collaborator

I've been bit by calling pr$handle("GET", "index.html",....). Needed to be pr$handle("GET", "/index.html", ....)

Like we did for mounted routers, should we prepend a / on the route if it doesn't have one?
@schloerke schloerke added this to the v0.5.0 - Next CRAN release milestone Jul 31, 2020
@schloerke schloerke added difficulty: novice Anyone could help effort: low < 1 day of work help wanted Solution is well-specified enough that any community member could fix labels Jul 31, 2020
@schloerke schloerke mentioned this issue Aug 20, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: novice Anyone could help effort: low < 1 day of work help wanted Solution is well-specified enough that any community member could fix
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging a pull request may close this issue.

prepend a '/' at the beginning of all paths rstudio/plumber
1 participant
@schloerke