Ensures that mounted routers have a leading slash #501
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
schloerke
approved these changes
Oct 28, 2019
wch
reviewed
Oct 28, 2019
wch
reviewed
Oct 28, 2019
atheriel
force-pushed
the
fill-in-leading-slash-for-mounts
branch
from
dc13db6 to
2d5fb16
Compare
This also adds some small tests for correct handling of both leading and trailing slashes in mount paths. Co-authored-by: Winston Chang <winston@stdout.org>
atheriel
force-pushed
the
fill-in-leading-slash-for-mounts
branch
from
2d5fb16 to
06c3275
Compare
|
Should be good to go now. I added some additional tests and moved to using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #476. Since Plumber already ensures that there is a trailing slash, this just does the same for a leading slash as well, rather than issue an error (which was the other suggested solution).
The examples from that thread now work correctly.
PR task list:
devtools::document()