Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepend a '/' at the beginning of all paths #656

Merged
merged 2 commits into from
Aug 21, 2020
Merged

prepend a '/' at the beginning of all paths #656

merged 2 commits into from
Aug 21, 2020

Conversation

schloerke
Copy link
Collaborator

@schloerke schloerke commented Aug 20, 2020 •
edited
Loading

Fixes #625

PR task list:

  • Update NEWS
  • Add tests
  • [NA] Update documentation with devtools::document()

@schloerke schloerke added this to the v1.0.0 - Next CRAN release milestone Aug 20, 2020
@schloerke schloerke requested a review from cpsievert August 20, 2020 20:24
@schloerke schloerke merged commit af4adc3 into master Aug 21, 2020
@schloerke schloerke deleted the start_slash branch August 21, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpsievert cpsievert cpsievert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

If routes do not start with a /, should it be prepended?
2 participants
@schloerke @cpsievert