Body encoding #259
Closed
Body encoding #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for proposing this change! It looks like the CI build now has some failed tests in light of this change. Do you mind taking a look at those? |
|
I am looking into the failures tonight. I'll post back once I have them fixed. |
|
I accidentally closed and commented. The pull request is still valid, I will post once I have the tests taken care of. |
…ody is character and looking for charset
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
==========================================
+ Coverage 88.26% 88.32% +0.06%
==========================================
Files 24 24
Lines 1227 1242 +15
==========================================
+ Hits 1083 1097 +14
- Misses 144 145 +1
Continue to review full report at Codecov.
|
This was referenced Jun 1, 2018
Merged
schloerke
added a commit
that referenced
this pull request
Jun 4, 2018
This should fix #153. I added a test to validate that it does handle encoding issues, also I tested locally on my windows partition that it was broken and isn't now. #153: Cannot POST in UTF-8 under windows #259: Body Encoding * setting encoding to fix windows problems * changing where setting encoding to ease testing * adding test for encoding * fixing encoding test (windows botched commit) * fixing bad assumption that everything is UTF-8, now checking if the body is character and looking for charset * adding a test for postBodyFilter * natural collate order * lints Co-authored-by: Jeremy Farrell @farrjere
|
Closing as merged in #264 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #153. I added a test to validate that it does handle encoding issues, also I tested locally on my windows partition that it was broken and isn't now.
I couldn't see any rules for contributing so please let me know if there is something else I need to do. I did sign the agreement though.