Handle non base64 encoded javascript from pandoc #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… preserved. Checking for base64 encoded images is still valid for the htmlwidgets test to make sure it is self contained. "SelfContained: don't use data URIs for script or style.": jgm/pandoc@7c0a80c
|
|
Codecov Report
@@ Coverage Diff @@
## master #263 +/- ##
==========================================
- Coverage 87.29% 86.94% -0.35%
==========================================
Files 25 25
Lines 1251 1088 -163
==========================================
- Hits 1092 946 -146
+ Misses 159 142 -17
Continue to review full report at Codecov.
|
schloerke
changed the title
schloerke
added a commit
to schloerke/plumber
that referenced
this pull request
Jun 4, 2018
* master: Handle non base64 encoded javascript from pandoc (rstudio#263)
schloerke
added a commit
to schloerke/plumber
that referenced
this pull request
Jun 4, 2018
* master: Handle non base64 encoded javascript from pandoc (rstudio#263)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javascript is not being encoded by default anymore. When reading the saved widget file, the new lines must be preserved to keep the javascript functioning.
In the tests, checking for base64 encoded images is still valid within the htmlwidgets test to make sure it is self contained.
Reference:
"SelfContained: don't use data URIs for script or style.": jgm/pandoc@7c0a80c