Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGBカメラのモデルを表示できるように変更 #45

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

YusukeKato
Copy link

@YusukeKato YusukeKato commented Oct 20, 2023

What does this implement/fix?

use_rgb_cameraをtrueにするとRGBカメラ(Realsense D435)のモデルを搭載したラズパイマウスがRViz上に表示されます。

Does this close any currently open issues?

しません。

How has this been tested?

下記のコマンドを実行するとRGBカメラを搭載したラズパイマウスがRViz上に表示されます。

ros2 launch raspimouse_description display.launch.py use_rgb_camera:=true

Any other comments?

Checklists

@YusukeKato YusukeKato added the Type: Feature New Feature label Oct 20, 2023
@YusukeKato YusukeKato self-assigned this Oct 20, 2023
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいところをコメントしました。確認おねがいします

declare_arg_use_rgb_camera = DeclareLaunchArgument(
'use_rgb_camera',
default_value='false',
description='Set "true" to rgb camera.')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description='Set "true" to rgb camera.')
description='Set "true" to mount rgb camera.')

use_nominal_extrinsics="false"
add_plug="false"
use_mesh="true">
<origin xyz="0.08 0.0 0.05" rpy="0 0 0"/>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

細かいですが、板厚含めると55がちょうど良さそうです。

Suggested change
<origin xyz="0.08 0.0 0.05" rpy="0 0 0"/>
<origin xyz="0.08 0.0 0.055" rpy="0 0 0"/>

YusukeKato and others added 2 commits October 23, 2023 13:51
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Copy link

@ShotaAk ShotaAk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShotaAk
Copy link

ShotaAk commented Oct 23, 2023

#30
ではカメラマウントのメッシュファイルが作成&追加されています。

別PRでros2 ブランチにも取り入れましょう。

@ShotaAk ShotaAk merged commit 576a35b into ros2 Oct 23, 2023
2 checks passed
@ShotaAk ShotaAk deleted the add-rgb-camera branch October 23, 2023 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature New Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants