-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RGBカメラのモデルを表示できるように変更 #45
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かいところをコメントしました。確認おねがいします
launch/display.launch.py
Outdated
declare_arg_use_rgb_camera = DeclareLaunchArgument( | ||
'use_rgb_camera', | ||
default_value='false', | ||
description='Set "true" to rgb camera.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
description='Set "true" to rgb camera.') | |
description='Set "true" to mount rgb camera.') |
urdf/raspimouse.urdf.xacro
Outdated
use_nominal_extrinsics="false" | ||
add_plug="false" | ||
use_mesh="true"> | ||
<origin xyz="0.08 0.0 0.05" rpy="0 0 0"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
細かいですが、板厚含めると55がちょうど良さそうです。
<origin xyz="0.08 0.0 0.05" rpy="0 0 0"/> | |
<origin xyz="0.08 0.0 0.055" rpy="0 0 0"/> |
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
Co-authored-by: Shota Aoki <s.aoki@rt-net.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
#30 別PRでros2 ブランチにも取り入れましょう。 |
What does this implement/fix?
use_rgb_cameraをtrueにするとRGBカメラ(Realsense D435)のモデルを搭載したラズパイマウスがRViz上に表示されます。
Does this close any currently open issues?
しません。
How has this been tested?
下記のコマンドを実行するとRGBカメラを搭載したラズパイマウスがRViz上に表示されます。
Any other comments?
Checklists