Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build status to README #28

Merged
merged 5 commits into from
Oct 14, 2020
Merged

Add build status to README #28

merged 5 commits into from
Oct 14, 2020

Conversation

Tiryoh
Copy link
Contributor

@Tiryoh Tiryoh commented Oct 14, 2020

What does this implement/fix?

上記PRにてバイナリリリースに対応したのでビルドステータスを表示します。

Does this close any currently open issues?

しません

How has this been tested?

READMEのみの変更です

Any other comments?

Checklists

  • I have read the CONTRIBUTING guidelines.
  • I have checked to ensure there aren't other open Pull Requests for the same change.

@Tiryoh Tiryoh added the Type: Documentation Documentation only changes label Oct 14, 2020
@Tiryoh Tiryoh requested a review from ShotaAk October 14, 2020 05:58
@ShotaAk
Copy link
Contributor

ShotaAk commented Oct 14, 2020

細かい話ですが、
KineticとMelodicのsourceビルドリンク先は、Dashingと合わせるなら下記になりますかね?
(どれがどう違うのかちゃんと把握できてないです)

http://build.ros.org/job/Msrc_uB__rt_usb_9axisimu_driver__ubuntu_bionic__source/
http://build.ros.org/job/Ksrc_uX__rt_usb_9axisimu_driver__ubuntu_xenial__source/

@Tiryoh
Copy link
Contributor Author

Tiryoh commented Oct 14, 2020

細かい話ですが、
KineticとMelodicのsourceビルドリンク先は、Dashingと合わせるなら下記になりますかね?
(どれがどう違うのかちゃんと把握できてないです)

http://build.ros.org/job/Msrc_uB__rt_usb_9axisimu_driver__ubuntu_bionic__source/
http://build.ros.org/job/Ksrc_uX__rt_usb_9axisimu_driver__ubuntu_xenial__source/

そうですね、指摘ありがとうございます。現状だとROS wikiに表示されるパッケージステータスの更新状況が表示されてますね🤔
直します。

@ShotaAk
Copy link
Contributor

ShotaAk commented Oct 14, 2020

確認しました。良いと思います。

@ShotaAk ShotaAk merged commit 28a40a1 into master Oct 14, 2020
@ShotaAk ShotaAk deleted the add-build-status branch October 14, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Documentation only changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants