Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.1.0] Management page no longer loads in Waterfox browser #141

Closed
luckysgb opened this issue May 21, 2020 · 4 comments
Closed

[v6.1.0] Management page no longer loads in Waterfox browser #141

luckysgb opened this issue May 21, 2020 · 4 comments
Assignees
Labels
Milestone

Comments

@luckysgb
Copy link

The Filter Management page will not load in Waterfox after updating to 6.1.0 (despite the Firefox addon being marked as compatible at the corresponding version) and only shows a blank page. The following error appears in the developer console:

TypeError: Object.fromEntries is not a function (manage.js:77:94675)

It was working in 6.0.0 and older versions. I am using the latest version of Waterfox Classic (2020.05 64-bit)

@rthaut rthaut added the bug label May 21, 2020
@rthaut rthaut added this to the v6.1.1 milestone May 21, 2020
@rthaut rthaut self-assigned this May 21, 2020
@rthaut
Copy link
Owner

rthaut commented May 21, 2020

Thanks for the detailed report.

MDN claims Object.fromEntries is compatible with Firefox 63+, which was released on October 23, 2018.

It seems odd to me that Waterfox doesn't support it, but I can easily swap that out for something else, likely either Lodash's fromPairs method or this ES6 alternative.

@luckysgb are you able to load an unsigned add-on from a ZIP file, instead of from the Firefox Add-Ons site? If so, would you like me to send an unsigned version of 6.1.1 for you to test before I publish?

@rthaut rthaut mentioned this issue May 22, 2020
rthaut added a commit that referenced this issue May 23, 2020
* feat: allow configuration of if/when to show release notes after update

* fix: only show create filter modal on requesting tab; fixes #140

* feat: apply user filters to status updates

* fix: hide metadata indicators on status updates

* fix: remove (currently) unused history permission

* chore: don't export `useStyles()` for MetadataFiltersForm component

* chore: update markdownlint rules configuration

* chore: remove bootstrap dependency from renovate package rules

* chore: remove version definition from source manifest.json file

* chore: remove empty CONTRIBUTING.md file

* update version to v6.1.1; add v6.1.1 release notes page

* replace `Object.fromEntries` with reducer (re #141)

* update Chrome and Firefox minimum versions

* chore: attempt to use browserslist to avoid compatibility issues

* chore: add browserslist to project dictionary files

* chore: remove unused (and invalid) tasks.json file

* adjust verbiage of "show update page" menu options

* adjust error verbiage/display in create filters modal

* feat: open release notes page in background on update

* reject fetch metadata promises with error on failure

* docs: add bug fix for Waterfox to v6.1.1 release page

* chore: update dependencies
@rthaut
Copy link
Owner

rthaut commented May 23, 2020

This should be fixed in v6.1.1, which was just released.

If it still doesn't work after updating, feel free to add another comment to this issue (preferred if the error from the console is the same), or open a new issue (preferred if the console error is different now).

@rthaut rthaut closed this as completed May 23, 2020
@luckysgb
Copy link
Author

Sorry, I didn't have a chance to test this until now. I can confirm that this issue is fixed for Waterfox in v6.1.1. Thank you!

However, starting with v6.1.1, the addon shows as incompatible: "This add-on requires a newer version of Firefox (at least version 62.0). You are using Firefox 57.0." I don't think that was the case before. Was that intentional?

(FYI - Waterfox Classic is locked at 57.0 maintain support for pre-WebExtension addons, but stays up-to-date with other Firefox updates, such as security fixes.)

I'd fully understand if you make changes at some point that require a newer version, but as far as I can tell, it still works other than the version check.

@rthaut
Copy link
Owner

rthaut commented May 24, 2020

However, starting with v6.1.1, the addon shows as incompatible: "This add-on requires a newer version of Firefox (at least version 62.0). You are using Firefox 57.0." I don't think that was the case before. Was that intentional?

@luckysgb It was indeed intentional, and was missed with the v6.1.0 release. I have made a new issue for tracking the minimum required Firefox version which covers the details, but basically Firefox version 62+ is needed for a feature introduced in DeviantArt Filter v6.1.0. Waterfox evidently has included the change that was introduced in Firefox version 62. If there is a way to specify a minimum Waterfox version (separate from the minimum Firefox version), that would be a good compromise; feel free to continue the discussion in that new issue.

Repository owner locked as resolved and limited conversation to collaborators May 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants