Many alias names #348
Merged
Many alias names #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
pyhys
reviewed
Feb 18, 2021
olbjo
force-pushed
the
many_alias_names
branch
3 times, most recently
from
c04fd51 to
ebad5dd
Compare
olbjo
force-pushed
the
many_alias_names
branch
2 times, most recently
from
ea8906f to
88be926
Compare
olbjo
force-pushed
the
many_alias_names
branch
from
88be926 to
a943157
Compare
hefloryd
reviewed
Feb 23, 2021
src/common/pf_dcp.c
Outdated
| skip = append_alias_name ? 0 : 1; | ||
| value_length = (uint16_t)strlen ((char *)p_value); | ||
| skip = alias_name ? 0 : 1; | ||
| if (skip == 0) |
There was a problem hiding this comment.
Skip is a boolean, skip = alias_name == NULL and if (!skip)?
Do not store alias name for each LLDP peer. Instead build and check alias when alias is part of id request received.
olbjo
force-pushed
the
many_alias_names
branch
from
a943157 to
36b09bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle multiple alias names.