Soft mac filtering #349
Closed
Soft mac filtering #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyhys
approved these changes
Feb 18, 2021
fredrikdanielmoller
suggested changes
Feb 18, 2021
| @@ -122,6 +149,18 @@ int pf_eth_recv (pnal_eth_handle_t * eth_handle, void * arg, pnal_buf_t * p_buf) | |||
| uint16_t ix = 0; | |||
| pnet_t * net = (pnet_t *)arg; | |||
|
|
|||
| #ifndef UNIT_TEST | |||
| /* Reject unicast packets with destination not matching | |||
There was a problem hiding this comment.
Wouldn't it be better if unicast filtering was done at a lower level (ie pnal)? Documentation could be added to pnal_eth_init() to require that incoming frames with unknown unicast destination MAC address should be dropped.
There was a problem hiding this comment.
I agree, we will start with only stop using promiscuous mode and retest to verify that this solves the original problem.
Moved initialization of mac addresses and lldp port name to stack.
Do not store alias name for each LLDP peer. Instead build and check alias when alias is part of id request received. Exclude alias name from DCP response as it shall only be used for filtering requests.
olbjo
force-pushed
the
soft_mac_filtering
branch
from
94dfe7c to
d864b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In promiscuous mode, ignore unicast packets that are not for this device.
Based on top of #333 and #348