Simplify configuration #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyhys
reviewed
Feb 10, 2021
include/pnet_api.h
Outdated
| char port_name[PNET_PORT_NAME_MAX_SIZE]; /**< Terminated string */ | ||
| uint16_t rtclass_2_status; | ||
| uint16_t rtclass_3_status; | ||
| pnet_netif_name_t port_netif; |
There was a problem hiding this comment.
Suggested change
| pnet_netif_name_t port_netif; | |
| const char * network_interface_name; |
(Assuming that pnet_cfg_t is no longer stored in pnet_t.)
There was a problem hiding this comment.
Remove pnet_cfg_t from pnet_t is out of the scope for this task. I will use name "netif_name".
There was a problem hiding this comment.
Beware that the copy of pnet_cfg_t in pnet_t will be a shallow copy, unless the strings are also copied.
pyhys
reviewed
Feb 12, 2021
olbjo
force-pushed
the
simplify_configuration
branch
6 times, most recently
from
b7d6ebf to
f8f567e
Compare
|
Comments handled, rebased on master. @pyhys I think you need to re-review updaes |
olbjo
force-pushed
the
simplify_configuration
branch
from
f8f567e to
1177f53
Compare
fredrikdanielmoller
suggested changes
Feb 17, 2021
Moved initialization of mac addresses and lldp port name to stack.
olbjo
force-pushed
the
simplify_configuration
branch
from
1177f53 to
c18e847
Compare
fredrikdanielmoller
approved these changes
Feb 18, 2021
olbjo
force-pushed
the
simplify_configuration
branch
from
c18e847 to
a58e9dd
Compare
|
Removed occurrence of PNET_MAX_PORT that emerged due to rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements part of enhancements suggested in #316.
Main change is that ethernet address and port name are not configuration parameters set by sample application.
To review the the update check out changes in pnet_api.h and pf_types.h rest of the updates follows from these updates.
A second commit renames PNET_MAX_PORT to PNET_NUMBER_OF_PHYSICAL_PORTS
Rebased on #332 to avoid future merge conflict.